Add prettier and format everything #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rescript-lang-org with
|
| Latest commit: |
a75d111
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://958f8de8.rescript-lang.pages.dev |
| Branch Preview URL: | https://vlk-add-prettier.rescript-lang.pages.dev |
…nto vlk/add-prettier
jderochervlk
force-pushed
the
vlk/add-prettier
branch
from
573e7d4 to
9cd7e09
Compare
|
Stick to the full defaults, I'd say. It makes ReScript stand out more as well ;-) |
|
Also what do you think about adding a format check in CI? Can be in another PR of course. |
I added a CI check and a pre-commit hook. I noticed we didn't have anything set up for hooks, so I added Lefthook. |
|
I think that's overkill. Can we rather nudge devs to have the correct formatter executed on save? |
Sure, I can remove the pre-commit hook. |
jderochervlk
force-pushed
the
vlk/add-prettier
branch
from
2683af8 to
a75d111
Compare
fhammerschmidt
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only default I didn't use was semicolons. Not using them makes the JS look more like ReScript, which I think is nice.